MMDevice: Remove need for _CRT_SECURE_NO_WARNINGS #438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marktsuchida
force-pushed
the
mmdevice-crt-secure-warnings
branch
from
5a04449 to
43ad126
Compare
That is, remove use of strcpy(), strncpy(), and getenv(). Replace str[n]cpy() with snprintf(). Add tests in the case of CDeviceUtils::CopyLimitedString() (previous implementation had a bug where it didn't null-terminate if the source string was exactly MM::MaxStrLength - 1 chars long). The use of getenv() was dead code, so remove entirely.
marktsuchida
force-pushed
the
mmdevice-crt-secure-warnings
branch
from
43ad126 to
ef695e4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That is, remove use of
strcpy(),strncpy(), andgetenv().Replace
str[n]cpy()withsnprintf(). Add tests in the case ofCDeviceUtils::CopyLimitedString()(previous implementation had a bug where it didn't null-terminate if the source string was exactlyMM::MaxStrLength - 1chars long).The use of
getenv()was dead code, so remove entirely.